Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dup cache consts and respect index size param #2948

Merged
merged 2 commits into from
Sep 29, 2024
Merged

fix: remove dup cache consts and respect index size param #2948

merged 2 commits into from
Sep 29, 2024

Conversation

BubbleCal
Copy link
Contributor

  • remove dup cache size consts
  • replace the index size param

@BubbleCal
fix: remove dup cache consts and respect index size param
d46e93d 
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Sep 28, 2024
@BubbleCal
fmt
29145e2 
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (681db8c) to head (29145e2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2948   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files         234      234           
  Lines       72822    72829    +7     
  Branches    72822    72829    +7     
=======================================
+ Hits        57525    57531    +6     
+ Misses      12332    12324    -8     
- Partials     2965     2974    +9
Flag Coverage Δ
unittests 78.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal marked this pull request as ready for review September 28, 2024 15:48
@BubbleCal BubbleCal merged commit 396b4d1 into lancedb:main Sep 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chebbyChefNEQ chebbyChefNEQ chebbyChefNEQ approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BubbleCal @codecov-commenter @chebbyChefNEQ